[JEWEL-1024] Improvements to SpeedSearchArea to support using for filter #3361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
requested review from
daaria-s,
nebojsa-vuksic,
rock3r and
wellingtoncosta
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
from
9ed15c7 to
8857fc4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...jewel/foundation/src/main/kotlin/org/jetbrains/jewel/foundation/lazy/SelectableLazyColumn.kt
Outdated
Show resolved
Hide resolved
...ewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/search/SpeedSearchableLazyColumn.kt
Show resolved
Hide resolved
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
2 times, most recently
from
dc7354c to
f2d590a
Compare
wellingtoncosta
approved these changes
Jan 8, 2026
Collaborator
wellingtoncosta
left a comment
wellingtoncosta
left a comment
There was a problem hiding this comment.
Just small suggestions, LGTM overall.
...jewel/foundation/src/test/kotlin/org/jetbrains/jewel/foundation/search/IterableFilterTest.kt
Outdated
Show resolved
Hide resolved
...jewel/foundation/src/test/kotlin/org/jetbrains/jewel/foundation/search/IterableFilterTest.kt
Outdated
Show resolved
Hide resolved
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
from
f2d590a to
d541a52
Compare
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SpeedSearchArea.kt
Show resolved
Hide resolved
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
from
d541a52 to
953694e
Compare
Collaborator
Author
|
FYI, I've added a warning banner to the new screen mentioning that the speed search component is not intended to this behavior. I'm also working on JEWEL-849, but it is taking a bit longer than I expected. 
|
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SpeedSearchArea.kt
Outdated
Show resolved
Hide resolved
rock3r
reviewed
Jan 14, 2026
...jewel/foundation/src/main/kotlin/org/jetbrains/jewel/foundation/search/SpeedSearchMatcher.kt
Outdated
Show resolved
Hide resolved
...jewel/foundation/src/main/kotlin/org/jetbrains/jewel/foundation/search/SpeedSearchMatcher.kt
Outdated
Show resolved
Hide resolved
...jewel/foundation/src/main/kotlin/org/jetbrains/jewel/foundation/search/SpeedSearchMatcher.kt
Outdated
Show resolved
Hide resolved
...s/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/views/ComponentsViewModel.kt
Outdated
Show resolved
Hide resolved
...ewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/search/SpeedSearchableLazyColumn.kt
Show resolved
Hide resolved
| @ExperimentalJewelApi | ||
| @ApiStatus.Experimental | ||
| @Deprecated("Kept for binary compatibility", level = DeprecationLevel.HIDDEN) | ||
| public fun SpeedSearchArea( |
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/SpeedSearchArea.kt
Outdated
Show resolved
Hide resolved
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
from
953694e to
7d7b12b
Compare
- Fixed index emission on SelectableLazyColumn when the selection changes by the speed search - Created 'EmptySpeedSearchMatcher' to easily identify when the filter text is empty - This matches is automatically returned in the SpeedSearchState.matcher when the text is empty - Added 'dismissOnLoseFocus' to SpeedSearchArea to keep the filter when the focus is left from the component - Added 'currentMatcher' to the 'SpeedSearchState', allowing the user use it for filtering purposes - Created convenience function on top of 'SpeedSearchMatcher' to check if the given text matches or not - Created convenience functions to support filtering collections based on the speed search matcher
faogustavo
force-pushed
the
gv/JEWEL-1204
branch
from
7d7b12b to
9bfb03a
Compare
| Snapshot.withMutableSnapshot { | ||
| textFieldState.edit { delete(0, length) } | ||
| searchText = "" | ||
| } |
There was a problem hiding this comment.
clearSearch doesn't reset currentMatcher causing stale filter state
Medium Severity
The clearSearch() method clears textFieldState and searchText within a Snapshot.withMutableSnapshot block but does not update currentMatcher to EmptySpeedSearchMatcher. The currentMatcher is only updated asynchronously by the flow running on a background dispatcher. This creates a race condition where consumers using currentMatcher for filtering (like derivedStateOf { list.filter(speedSearchState.currentMatcher) }) may see stale filter results after the search is cleared, causing a brief visual flicker where the list stays filtered even though the search input has disappeared.
rock3r
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidences
Release notes
New features
Bug fixes
Note
Introduces filtering-friendly SpeedSearch and related API updates, plus selection emission fixes and samples/tests.
EmptySpeedSearchMatcher,CharSequence.matches, andIterable.filter(...)helpers;SpeedSearchMatcher.matchesnow acceptsCharSequenceSpeedSearchArea: new overloads with externalSpeedSearchState,rememberSpeedSearchState, anddismissOnLoseFocusflag; exposesSpeedSearchState.currentMatcher,isVisiblesetter, and internaltextFieldState; batching + matcher caching for performanceSpeedSearchableLazyColumnscroll logic to sync with search/selection; wires attach flows; improves index sync when search is clearedSelectableLazyColumnto emitonSelectedIndexesChangewhen SpeedSearch changes selection and to resynclastActiveItemIndexSpeedSearches), icon, and comprehensive UI/tests (including filtering behavior and focus-dismiss cases)Written by Cursor Bugbot for commit 9bfb03a. This will update automatically on new commits. Configure here.